Add workflow to add/update offline docs #757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leptos-null
reviewed
Jul 22, 2023
leptos-null
reviewed
Jul 22, 2023
leptos-null
reviewed
Jul 22, 2023
leptos-null
reviewed
Jul 30, 2023
There was a problem hiding this comment.
Overall this code looks good. The workflow will not work though, for two reasons:
secrets.GITHUB_TOKENdoes not have sufficient permissions to write to this repository/ branch, I believe- the trigger for this workflow is
on: push: branches: masterhowever this is unrelated to the event that we're interested in, which is pushes tomasterontheos/theos.dev- both Lightmann and I originally thought this would work because
update-submoduleswould run on organization pushes, however pushes totheos.devwould not result in a commit to this repository and therefore would not trigger this workflow
- both Lightmann and I originally thought this would work because
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
See title
Does this close any currently open issues?
No, but it will tick another item off of #308
Any relevant logs, error output, etc?
Any other comments?
Tested on separate branch and worked like a charm. Would be nice if we could only run the workflow if theos/theos.dev is updated, but not sure that's possible.
Edit: CSS looks to be borked atmWhere has this been tested?
Operating System: …
Linux (WSL)
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …