Validate project paths #756
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabiroberai
requested changes
Jul 24, 2023
Comment on lines
+275
to
+283
| ifneq ($(call __validate,$(THEOS_BUILD_DIR)),$(_THEOS_TRUE)) | ||
| $(error “$(THEOS_BUILD_DIR)” either contains spaces or does not exist) | ||
| else ifneq ($(call __format_validate,$(THEOS_OBJ_DIR)),$(_THEOS_TRUE)) | ||
| $(error “$(THEOS_OBJ_DIR)” contains spaces which are not supported in project paths) | ||
| else ifneq ($(call __format_validate,$(THEOS_STAGING_DIR)),$(_THEOS_TRUE)) | ||
| $(error “$(THEOS_STAGING_DIR)” contains spaces which are not supported in project paths) | ||
| else ifneq ($(call __format_validate,$(THEOS_PACKAGE_DIR)),$(_THEOS_TRUE)) | ||
| $(error “$(THEOS_PACKAGE_DIR)” contains spaces which are not supported in project paths) | ||
| endif |
There was a problem hiding this comment.
I think we can afford to skip these checks
There was a problem hiding this comment.
I'm not entirely sure I agree, considering they're defined conditionally (?=), but am fine to revert if we want to take a more lenient approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
See title
Does this close any currently open issues?
No
Any relevant logs, error output, etc?
Any other comments?
Issue of custom paths potentially containing spaces and not being escaped/quoted was brought up by Ethan Arbuckle a few months back in the Theos discord. Was unsure if a fix had been proposed elsewhere, so figured I'd pr mine. Open to feedback/changes.
Where has this been tested?
Operating System: …
Linux (WSL)
Platform: …
Target Platform: …
Toolchain Version: …
SDK Version: …