Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXX Usage Modifications #754

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

CXX Usage Modifications #754

wants to merge 6 commits into from

Conversation

L1ghtmann
Copy link
Member

What does this implement/fix? Explain your changes.

  • Switches relevant file types to CC from CXX
  • Defaults to CC for linking and only switches to CXX if OBJ_FILES_TO_LINK contains a ++ file variant
  • Skips passing the ++ LD flags if using the CC for linking
  • Removes explicit link to libc++ as the CXX seems to auto-link it when used as the linker

Does this close any currently open issues?

No

Any relevant logs, error output, etc?

Any other comments?

Not tested extensively. Just messages=yes tests to confirm the changes made were effective. Open to discussion.

Where has this been tested?

Operating System: …

Linux (WSL)

Platform: …

Target Platform: …

Toolchain Version: …

SDK Version: …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uroboro uroboro uroboro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@L1ghtmann @uroboro