Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote installs with non-root THEOS_DEVICE_USER failing #743

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

L1ghtmann
Copy link
Member

What does this implement/fix? Explain your changes.

See title

Does this close any currently open issues?

I don't think so

Any relevant logs, error output, etc?

Upstream:

$ make install THEOS_DEVICE_USER=mobile
(mobile@xxx.xxx.x.xxx) Password for mobile@device:
==> Installing…
dpkg: error: requested operation requires superuser privilege
make: *** [/home/lightmann/theos/makefiles/install/deb_remote.mk:2: internal-install] Error 2

Fork:

$ make install THEOS_DEVICE_USER=mobile
(mobile@xxx.xxx.x.xxx) Password for mobile@device:
==> Installing…
[sudo] password for mobile: (Reading database ... 10559 files and directories currently installed.)
Preparing to unpack /tmp/_theos_install.deb ...
Unpacking me.lightmann.iamlazy (2.2.0-52+debug) over (2.2.0-52+debug) ...
Setting up me.lightmann.iamlazy (2.2.0-52+debug) ...
Processing triggers for uikittools (2.1.6-1) ...
(mobile@xxx.xxx.x.xxx) Password for mobile@device:
==> Unloading IAmLazy…
> Making after-install in AndSoAreYou…
> Making after-install in postinst…

Any other comments?

  • This fix is relevant as root is not setup by default on newer jailbreaks
  • Removed THEOS_SUDO_COMMAND as sudo is used on all platforms and is not darwin specific
    • I checked and this does not seem to be in use in any OS projects
  • The fix is less than ideal, as it makes an assumption and deals with credentials, but I couldn't figure out how to prompt the user and figured I'd get something out there for discussion.

Where has this been tested?

Operating System:

Linux (WSL) + iP7 15.4.1 palera1n (rootless)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@L1ghtmann L1ghtmann marked this pull request as draft August 23, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant