Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a retired script from THEOS_BIN #689

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

L1ghtmann
Copy link
Member

@L1ghtmann L1ghtmann commented Jan 7, 2023

What does this implement/fix? Explain your changes.

  • Merges install.mergeDir, install.copyFile, and install.exec into a single install.sh script
  • Explicitly uses $THEOS_BIN_PATH in each invocation (just to be safe)
  • Removes deb_build_num.sh as it was retired more than a decade ago in 362fafc

Does this close any currently open issues?

I don't think so, no

Any relevant logs, error output, etc?

N/A

Any other comments?

I tested this by running make do and it seemed to hold up!

Where has this been tested?

Operating System:

Linux (WSL)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@kabiroberai
Copy link
Member

I'm in favour of removing deb_build_num.sh, and to some extent specifying $THEOS_BIN_PATH for the install invocations (though this does remove the ability to override the scripts via the PATH).

Wrt the install script files though, is there a compelling reason to merge them into one? I'm in the "if it ain't broke don't fix it" camp in that case, especially because there may be other tools/modules relying on those scripts, and (imo) bundling them increases cognitive overhead. I can be convinced otherwise if other people disagree though.

@kirb
Copy link
Member

kirb commented Feb 9, 2023

install.exec is used in far too many projects for us to remove it. If we merge them we still need to support these, but then we may as well not do this refactoring if the originals need to be kept around to redirect to the new equivalents anyway.

@L1ghtmann
Copy link
Member Author

Oop, that's fair. Worth doing the deb_build_num.sh and/or $THEOS_BIN_PATH changes or should I just scrap this pr?

@kabiroberai
Copy link
Member

Let's avoid the $THEOS_BIN_PATH change since the templates don't use it. I'm good with removing deb_build_num.sh to reduce clutter.

@L1ghtmann L1ghtmann changed the title Merge install.* scripts into one and remove a retired script Remove a retired script from THEOS_BIN Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants