Document unit conventions #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 61 61
Lines 6605 6605
Branches 847 847
=======================================
Hits 6312 6312
Misses 136 136
Partials 157 157 Continue to review full report at Codecov.
|
BradenDKelly
approved these changes
Sep 2, 2020
There was a problem hiding this comment.
Looks good, thanks for adding the clarification on units! We may need @FarnazH to approve as well, or you may need to self approve. While my approval may be a necessary condition, it is not a sufficient condition :)
|
Thanks for taking a look. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm documenting the unit conventions because this was not entirely obvious. See #198.