Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(remix): added additional notes for using Remix Link API #1280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhavalveera
Copy link
Contributor

if we are using Remix API Layer Link from @remix-run/react, and using it == as={Link} then replace the href with to, and we can use href if we are not using Link on Navbar.Link & Sidebar.Item

if we are using Remix API Layer Link from @remix-run/react, and using it == as={Link} then replace
the href with to, and we can use href if we are not using Link on naNavbar.Link & Sidebar.Item
Copy link

stackblitz bot commented Feb 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:00am

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (7461173) to head (3657feb).
Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   99.54%   97.35%   -2.20%     
==========================================
  Files         163      216      +53     
  Lines        6621     9224    +2603     
  Branches      401      538     +137     
==========================================
+ Hits         6591     8980    +2389     
- Misses         30      244     +214     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhavalveera
Copy link
Contributor Author

Hello @SutuSebastian , Sorry to bother you, but can you please review this PR?

Copy link
Collaborator

@SutuSebastian SutuSebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we simplify the text a bit? so its more concise and easier to understand

@dhavalveera
Copy link
Contributor Author

can we simplify the text a bit? so its more concise and easier to understand

I wrote this explanation with examples for better understanding. but let me try if I can simplify the text. @SutuSebastian

@SutuSebastian
Copy link
Collaborator

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

@dhavalveera
Copy link
Contributor Author

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

Sounds Great!.. I would be happy to help you & contribute with you more on this.

@dhavalveera
Copy link
Contributor Author

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.

Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

@SutuSebastian
Copy link
Collaborator

Actually, let's wait with this since we'll have a new way of making navigation more friendly and top level config, so the developer doesn't have to repeat itself in all places.
Logic behind: register once -> it just works.

can I close this PR? @SutuSebastian

keep it for a while, so we can close it with reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants