fix(dropdown.tsx): handling the Placeholder if the label isnt provided #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the Dropdown - the label has to be passed, if the there is no label, then showing default placeholder fix themesberg#1260
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
- Coverage 99.54% 97.35% -2.20%
==========================================
Files 163 216 +53
Lines 6621 9224 +2603
Branches 401 538 +137
==========================================
+ Hits 6591 8980 +2389
- Misses 30 244 +214 ☔ View full report in Codecov by Sentry. |
|
Hello @SutuSebastian , Sorry to bother you, can you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the Dropdown - the label has to be passed, if the there is no label, then showing default placeholder
fix #1260