Fix/timeline vertical #1224
Open
Fix/timeline vertical #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make root.base independent from component orientation, introduce orientation-specific classes fix themesberg#1196
SutuSebastian
force-pushed
the
fix/timeline-vertical
branch
from
f484201
to
eeca82c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SutuSebastian
requested changes
Feb 5, 2024
| @@ -14,6 +14,8 @@ import type { FlowbiteTimelineTitleTheme } from './TimelineTitle'; | |||
| export interface FlowbiteTimelineContentTheme { | |||
| root: { | |||
| base: string; | |||
| vertical?: string; | |||
There was a problem hiding this comment.
these are redundant, can be removed
| @@ -14,6 +14,8 @@ import type { FlowbiteTimelineTitleTheme } from './TimelineTitle'; | |||
| export interface FlowbiteTimelineContentTheme { | |||
| root: { | |||
| base: string; | |||
| vertical?: string; | |||
| horizontal?: string; | |||
|
Deployment failed with the following error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem with vertical-oriented
<Timeline.Content />component style. Theroot.baseclass theme prop is now independent on orientation. The optionalroot.verticalandroot.horizontalprops were introduced to make orientation-specific style changes.Fix #1196
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
interface FlowbiteTimelineContentThemehas been changed. The theme now supports optionalroot.verticalandroot.horizontalprops.