Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for placeholder in Dropdown #1260

Open
2 tasks done
victorfunes opened this issue Feb 3, 2024 · 1 comment · May be fixed by #1263
Open
2 tasks done

Support for placeholder in Dropdown #1260

victorfunes opened this issue Feb 3, 2024 · 1 comment · May be fixed by #1263

Comments

@victorfunes
Copy link

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Summary

Now the Dropdown has a placeholder property but it seems not being used.
Does it make sense to enable it to be used when the label is not defined?

Maybe I am using it as a select incorrectly, but I don't like the style of the Select floating menu...
If there is another way, any advise will be more than welcome.

Context

In case a dropdown label is initially not defined, it could show the placeholder.
Now I am doing it from my components using:

<Dropdown label={label ?? placeholder} ...
@SutuSebastian
Copy link
Collaborator

This would be a good addition to the existing API layer of the component.

dhavalveera added a commit to dhavalveera/flowbite-react that referenced this issue Feb 6, 2024
@dhavalveera
fix(dropdown.tsx): handling the Placeholder if the label isnt provided
19abe49 
currently the Dropdown - the label has to be passed, if the there is no label, then showing default
placeholder

fix themesberg#1260
@dhavalveera dhavalveera linked a pull request Feb 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dropdown.tsx): handling the Placeholder if the label isnt provided dhavalveera/flowbite-react
2 participants
@SutuSebastian @victorfunes