Ts update #4869
Merged
Ts update #4869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnre8
commented
May 4, 2024
| @@ -93,6 +93,7 @@ const tsRules = defineConfig({ | |||
| // note you must disable the base rule as it can report incorrect errors | |||
| "no-shadow": "off", | |||
| "@typescript-eslint/no-shadow": ["error"], | |||
| "@typescript-eslint/no-redundant-type-constituents": "off", | |||
There was a problem hiding this comment.
don't really see the point in making our types worse, even though it's technically correct that just having undefined as a type encompasses everything, but documentation wise that's poor.
brunnre8
commented
May 4, 2024
| expand: expand, | ||
| join: join, | ||
| search: search, | ||
| }; |
There was a problem hiding this comment.
This we probably also need to do with the other things that do the dynamic import...
While it does safe some typing, this is preventing us from moving to modules (we need top level imports or wait for the promise if we do it dynamically), is bad for tree shaking and simply put not needed as all our stuff is available at build time, we don't have plugins or such
Dynamic imports won't work very well with modules and we don't really need them, it's just there to save us an import statement. Let's flip this to a static version.
MaxLeiter
reviewed
May 5, 2024
| import {input as join} from "./join"; | ||
| import {input as search} from "./search"; | ||
|
|
||
| export const commands = { |
MaxLeiter
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump compiler to the latest, needs updated eslint as well, which lead to a bunch of errors that needed to be addressed.