Untangle client and server #4861
Commits on Apr 21, 2024
-
-
-
-
-
-
-
changelog: don't type assert to a broken type
The mandatory fields are unset, stop lying to the compiler
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
There were quite some errors, where the type was passed the wrong way ``` // This is invalid "change-password": ({ old_password: string, new_password: string, verify_password: string}) // What was actually meant "change-password": (data: { old_password: string, new_password: string, verify_password: string}) ``` The whole callback function is also very verbose as is, with fluff we don't need. It's always a function that returns void, so there's no real information to be gained by spelling it out time and time again. Let's use a helper type that just accepts the payload. That should make the above error impossible to do. -
-
The sort event bundled networks and channels for no reason at all. They share none of the actual logic, so combining them just makes the typing poor but serves no benefit.
-
-
-
-
-
-
-
-
-
-
-
network event: remove unused array
All the network events only ever emit a single copy There's no point in wrapping it into an array
-
-
-
publicClient: add FIXME and ignore the type mismatch
The publicClient interface is utterly horrific. It allows any client to inject arbitrary events into the socket.io event stream. This should get wrapped into a "plugin" event so that it can get properly typed, better yet, this should get removed completely.
-
-
-
-
socket-events/msg: if/else chains are not a switch replacement
If we switch on a field, use switch for god's sake. If/elif chains are for cases where you have multiple selectors.
-
-
-
-
-
-
-
add socket-events import to entry point
socket-events aren't ever imported, if we don't do that however webpack never actually sees any code that leads to it and skips bundling it. So for now, do an import that has the side effect of registering all the events until we have a proper registration in place that's a bit more sane to call
-
-
-
-
-
-
-
-
ignore: keep happy path on the left
It is much easier to follow the control flow if error checks are done on the indented path, immediately returning.
-
ignore: move ignorelist to its own command
ignorelist shares no logic with /ignore or /unignore so it shouldn't share a file. That just makes typing awkward.
-
ignore: clean up the types and conditionals
Now that ignorelist doesn't muddy the waters, we can clean up all the funny conditional types and enforce `when`
-
-
-
-
-
-
-
-
-
server: somewhat type fix auth related functions
The auth functions are a bloody mess and need to be cleaned up. using various callback functions and using variables as pointers makes the logic hard to follow and hence idiotic to type too, as multiple orthogonal logic paths are mixed up into one function. This really needs to be untangled
-
-
userAway is purely server side and we don't send it to the client
-
-
-
-
-
-
-
-
-
-
-
-
-
components/MessageTypes/errors: fix eslint errors
This makes the code somewhat ugly, but to properly fix we need to enforce the needed fields
-
test/chan: getFilteredClone has more fields than the test thinks
The codebase shoves various things into channel objects to transmit them for things like channel lists etc. This however means that the type does contains the fields and needs to export them. We should clean up the events so that we can get rid of all that. But for now, we adapt the test expectation to reality.
-
test/chan: remove users field from test
The client side fetches the user list when needed, we don't send it over from the server. Hence modify the test expectation.
-
test: token in init event payload is undefined not null
Doesn't matter which, code happens to emit undefined. Adapt test expectation over writing strange || null code. The conditional just checks for a falsey value.
-
-
NetworkForm: disable unsafe return lints for now
The NetworkForm type is wrong, hence the compiler can't infer the type. This needs quite some changes, so for now we just turn the linter off for the 2 watch functions. The whole component is too dynamic to fix easily.
-
server: don't throw in async callback from index requests
This was flagged as an issue by codeQL > Server crash [High] > The server of this route handler will terminate when an > uncaught exception from this location escapes an > asynchronous callback.
