Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(irc framework): support (client) tags #4774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RaitoBezarius
Copy link

@RaitoBezarius RaitoBezarius commented Aug 11, 2023

It is now possible to receive, send and process client tags in general using the IRC framework, adds also TAGMSG.

This is useful for many client-oriented IRCv3 features: typing, reacts, replies, channel contexts, etc.

This is step 1 for #2419 which I will slowly but surely finish.

@RaitoBezarius RaitoBezarius force-pushed the client-tags branch 4 times, most recently from da7e41e to ac5eb00 Compare August 11, 2023 02:02
@RaitoBezarius
Copy link
Author

I have kiwiirc/irc-framework#366 and some code for this PR to support client tag denies more properly, but I think it's better to do it in another PR.

Copy link
Member

@brunnre8 brunnre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, this is much appreciated.

I do have a few comments in regards to some of the code, hope it makes sense somewhat

server/models/msg.ts Outdated Show resolved Hide resolved
server/models/msg.ts Outdated Show resolved Hide resolved
server/plugins/inputs/msg.ts Outdated Show resolved Hide resolved
server/types/modules/irc-framework.d.ts Outdated Show resolved Hide resolved
server/plugins/irc-events/message.ts Outdated Show resolved Hide resolved
server/plugins/irc-events/message.ts Outdated Show resolved Hide resolved
It is now possible to receive, send and process client tags
in general using the IRC framework.

This is useful for many client-oriented IRCv3 features: typing,
reacts, replies, channel contexts, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants