sqlite: add full text search index #4767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now, this is the bare bones version that just supports normal phrases, no fancy wildcards, no prefix matches / and / or logic etc. FTS5 supports all that though so it's just a matter of coming up with a sane syntax and writing the parser for it: |
brunnre8
added
Type: Feature
MaxLeiter
approved these changes
Jan 27, 2024
|
Don't merge as is quite yet, this will not merge cleanly with the current master branch due to a security feature iirc... Need to rebase and relax the checks |
brunnre8
force-pushed
the
betterSearch
branch
from
dc097ef
to
a44a50f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
brunnre8
added
Meta: Do Not Merge
Our search was using a linear search over the message text data. This is very inefficient for large databases and barely usable. We can add an FTS index, trading storage for speed. As it's setup, this only supports English, but then we get fancy stemming so that say "work" matches itself as well as "working". This could be reduced to just stripping funny chars, with less good search in the English case.
brunnre8
force-pushed
the
betterSearch
branch
from
a44a50f
to
b2797c3
Compare
|
So, fixed the obvious bugs... @MaxLeiter would you mind re-running it on your machine and activate the storage cleaner with "everything" for a bit? Just to see if pragma trusted_schema might be needed or not? (That executes the on delete triggers, in case that wasn't obvious as to why I want you to do that) |
brunnre8
added
Status: needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our search was using a linear search over the message text data.
This is very inefficient for large databases and barely usable.
We can add an FTS index, trading storage for speed.
As it's setup, this only supports English, but then we get fancy
stemming so that say "work" matches itself as well as "working".
This could be reduced to just stripping funny chars, with less good
search in the English case.