Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent autocomplete space following username at login #4749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kufat
Copy link
Contributor

@Kufat Kufat commented Jun 10, 2023

No popup because this usually happens for reasons that aren't the user's fault.

No popup because this usually happens for reasons that aren't the user's fault.
@brunnre8
Copy link
Member

Thank you for the PR.
I don't think this is the right approach though, we should just switch the user input field to the normal v-model and let vue do it with the .trim modifier on it.
I've already PRed the rewrite #4753 so all that you need to do is add the trim modifier onto it.

@brunnre8 brunnre8 added the Status: changes-requested Review happened but some changes need to be made label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: changes-requested Review happened but some changes need to be made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants