Plugin input #4704
Merged
Plugin input #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnre8
added
Meta: Internal
MaxLeiter
reviewed
Mar 16, 2023
server/client.ts
Outdated
|
|
||
| if (inputs.userInputs.has(cmd)) { | ||
| const plugin = inputs.userInputs.get(cmd); | ||
| const plugin = inputs.userInputs.get(cmd)!; // this is only save because we just checked it |
There was a problem hiding this comment.
nit: I meant to suggest changes here, but I'd prefer something like #4714
There was a problem hiding this comment.
your PR over there fails the typing check though
MaxLeiter
reviewed
Mar 16, 2023
MaxLeiter
approved these changes
Mar 16, 2023
Keep happy path on the left and try to return as early as we can to help the reader understand the logic better The function is too large to be able to quickly scan an if / else chain and see the function return at the end
brunnre8
removed
the
Status: needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This types the public command API during the registration phase and reworks the input function to be a bit easier to understand, least for me.
Holler if you disagree, but I hate the pattern of
That (implicit) return right there is not even on screen when you start to read the first few clauses, so you have no idea what the function does at the end only to then scroll down and find out that it indeed just returns.
We already know that we are done, tell the reader accordingly.