search: add nick keyword search #4579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- search messages by author with `from:nick` - add section to Help.vue - should be easy to adapt this into global keyword-based search thelounge#4209
xPaw
reviewed
Jun 4, 2022
|
|
||
| if (filters && Object.keys(filters).length) { | ||
| if (filters.from) { | ||
| select += ' AND json_extract(msg, "$.from.nick") LIKE ?'; |
There was a problem hiding this comment.
Does this need ESCAPE, or do we expect from: to be exact matches, why use LIKE then?
xPaw
reviewed
Jun 4, 2022
| }) | ||
| ); | ||
|
|
||
| store.index( |
There was a problem hiding this comment.
I would add a few messages from users like thelounge007abc abcthelounge007, abcthelounge007abc to test whether there are partial nick matches.
xPaw
reviewed
Jun 4, 2022
| // - "from:nick" to find messages sent by a given nick | ||
| const keywords = ["from"]; | ||
| const joinedKeywords = keywords.map((kw) => kw + ":").join("|"); | ||
| const filterExp = RegExp(`((${joinedKeywords})(\\S+))+`, "g"); |
There was a problem hiding this comment.
Does this need \s* or \b? testfrom:xpaw
brunnre8
added
the
Status: changes-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from:nickHelp.vue#4209