Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding commands when creating a connection, support delays between commands #4557

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaxLeiter
Copy link
Member

@MaxLeiter MaxLeiter commented May 1, 2022

I'm fine with only accepting one commit or neither if they're contentious or I'm missing something.

This allows you to add commands on the new network form if webirc isn't enabled. It also introduces a /wait command, so you can wait 10 seconds between executing commands with

/wait 10
/msg bot command

Closes #1390

@MaxLeiter MaxLeiter added the Status: needs-review PR not yet reviewed by enough maintainers label May 1, 2022
@MaxLeiter MaxLeiter marked this pull request as draft May 1, 2022 09:37

resolve();
} else {
setTimeout(() => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to reset delay

@brunnre8
Copy link
Member

brunnre8 commented May 1, 2022

why would you want to prevent commands if webirc is enabled?
That should have nothing to do with each other no?

@MaxLeiter
Copy link
Member Author

MaxLeiter commented May 1, 2022

@brunnre8 I did it based on the existing comment. @xPaw, I believe you wrote this code initially, do you know why you excluded commands? If we do need to disable it, I'll hide it on the client if webirc is enabled.

/>
</div>
</template>
<template v-if="!$store.state.serverConfiguration.public">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a check for webirc too?

@xPaw
Copy link
Member

xPaw commented May 1, 2022

I can't remember the exact reason it was disabled, probably to not deal with public mode.

Co-authored-by: Pavel Djundik <xPaw@users.noreply.github.com>
@skubi23t
Copy link

Is there any chance to include this /wait command? I'm having issues with auto joining the channel as the bot sends invitation very slowly.

@Jayowski

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: needs-review PR not yet reviewed by enough maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling users to set delays between connect commands
5 participants