Add favoriting/pinning channels

[MaxLeiter]

Closes #180, #4078(?)

It effectively adds a new network, 'favorites' that can contain channels from any network.

If there's a name conflict, the server name is appended to the channel name while it's favorited.

The functionality all works except the command, as I'm not sure of how that should work.

I was thinking:

/favorites add [target] [...targets]
/favorites remove [target] [...targets]
/favorites clear

If no target is provided, it's assumed to be the current channel.

Here you can see two #testing123 channels with the server name attached. It's also added to the topic line, so (for example) on mobile you can be confident which you pressed

The Favorites 'network' can't be opened (clicking it does nothing), but does have a context menu:

You can add channels/queries to your favorites with the context menu (or aforementioned command):

[xPaw]

The functionality all works except the command, as I'm not sure of how that should work.

Sounds like the channel object should know which network it belongs to, so it should just work™.

[MaxLeiter]

@xPaw I meant the command interface:

I was thinking:

/favorites add [target] [...targets]
/favorites remove [target] [...targets]
/favorites clear

The alternative is
/favorite [target]
/unfavorite [target]
and not sure how clear would look

[xPaw]

Ah right, misunderstood.

The (un)favorite syntax would match all the existing commands.

[igalic]

it's always possible to have those be aliases
some people may find the first more intuitive and others the second

i for instance add aliases in git for tags, branches and remotes, which by default print those in a sensible (to me) format

[itsjohncs]

I'd give a vote for unfavorite and favorite. I think subcommands are nice as a way to do namespacing when there's a really huge number of commands (like git), but that's not the case here.

[brunnre8]

Let's go for consistency and /favorite + /unfavorite then? Or what's the consensus now?

[fnutt]

I agree about /favorite and /unfavorite. 👍 Good work @MaxLeiter!