Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/whois nick should go to currently active window #492

Open
dgw opened this issue Jul 11, 2016 · 7 comments · May be fixed by #4548
Open

/whois nick should go to currently active window #492

dgw opened this issue Jul 11, 2016 · 7 comments · May be fixed by #4548
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.

Comments

@dgw
Copy link
Contributor

dgw commented Jul 11, 2016

I don't know if there was any reason behind opening a query window for the nick requested in a /whois command, but it's pretty cumbersome to have to change windows.

One solution would be to focus the newly created query window, but that seems like bad UX. Most clients I've used send WHOIS responses to either the current window or the server console. Since the latter would still require changing windows, manually or automatically, I reject it as a possibility and propose that WHOIS output go to the currently active window.

@maxpoulin64 maxpoulin64 added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Jul 12, 2016
@maxpoulin64
Copy link
Member

Note: this suffers from the same problem as with notices: when there is no client attached, it's impossible to know where the result should go. It is also unclear when multiple clients are attached which window this should go to. So it will take a while before we get there, as handling this will require a special global channel for the clients to be able to display this sort of messages properly.

@dgw
Copy link
Contributor Author

dgw commented Jul 12, 2016

If no client is attached, notices can go to the server window. If multiple clients are attached, is it impractical for each client to decide where to place the incoming notice depending on which window is active?

@AlMcKinlay
Copy link
Member

I still think things like that should go to a modal window. Let's not just
keep thinking in old irc terms. We are building a modern web app, we can do
much better things.

A whois is generally something you use because you want to see something
now. You don't generally want to look at it later, and its not really going
to happen when someone is disconnected.

On Tue, 12 Jul 2016, 04:15 dgw, notifications@github.com wrote:

If no client is attached, notices can go to the server window. If multiple
clients are attached, is it impractical for each client to decide where to
place the incoming notice depending on which window is active?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#492 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACD_4ahaNDfk9tHCfw1MIDR0kf7vtyy6ks5qUwbGgaJpZM4JJsXy
.

@dgw
Copy link
Contributor Author

dgw commented Jul 12, 2016

Even if I weren't opposed to the idea of incoming data triggering a modal window, I'd still have questions about the UX of logged-on clients other than the one which sent the WHOIS request displaying a modal window upon receiving the response. And I am very much opposed to using modal windows except where absolutely necessary, because they're either annoying to get out of (only "Close" or similar button closes) or too easy to dismiss by accident (clicking anywhere outside the modal closes).

I did get a little distracted by the comparison to notices, and I'll add that feedback on the appropriate issue instead.

@AlMcKinlay
Copy link
Member

Oh, I'm not suggesting the ones that didn't request it showing a modal.

On Tue, 12 Jul 2016, 07:06 dgw, notifications@github.com wrote:

Even if I weren't opposed to the idea of incoming data triggering a modal
window, I'd still have questions about the UX of logged-on clients other
than the one which sent the WHOIS request displaying a modal window upon
receiving the response. And I am very much opposed to using modal windows
except where absolutely necessary, because they're either annoying to get
out of (only "Close" or similar button closes) or too easy to dismiss by
accident (clicking anywhere outside the modal closes).

I did get a little distracted by the comparison to notices, and I'll add
that feedback on the appropriate issue instead.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#492 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACD_4fS9HWdwYcpHwn-mVZguYjI69HPFks5qUy5PgaJpZM4JJsXy
.

@shinji257
Copy link

I'm going to suggest having it go to the server window. This avoids confusion on determining where it should go and avoids creating a useless chat window just for whois results.

@fuzzy76
Copy link

fuzzy76 commented Aug 22, 2018

Would the ideal behaviour depend on how you requested the information? Writing /whois user probably means you want the text output while right-click in the user list and selecting "User information" probably means you would prefer a dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
5 participants