-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add moransi #304
base: main
Are you sure you want to change the base?
Feat/add moransi #304
Conversation
Hi @michalk8, do you have an idea why the checks fail here? The file locally has no syntax errors and also passes the pre-commits I added as part of this PR. Do not know how to handle this best / fix it. |
Done. Also, I'd seriously consider refactoring the CI to be more up-to-date. |
Why does |
I did not set the CI up, I guess @mumichae and I would be very glad for your input to improve this :) |
It is, just from Python 3.8 (would deprecate 3.7 since numpy support ended last December), hence the refactoring. |
Thanks so much, @michalk8! |
Are you referring to the .github/workflow content to be updated based on a newer configuration template? I wasn't aware there was an update, what consequences would the current code have of not updated? Would be happy to update, however that would be in a separate PR. |
Would do the following:
The first 2 points I'd say are the one to focus on. |
Thanks a lot for the suggestions @michalk8 ! I think we should definitely make things more consistent, if we start using pre-commit (which we hadn't before). But I think this should be separated from Moran's I. I'll open a new issue with a description of what we'd need for pre-commit integration and would suggest we get that merged before the new metric. |
Updated version of #303 |
Move helper functions outside, only consider scores > 0, refactor code, reduce default n_hvg
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
+ Coverage 53.35% 56.90% +3.54%
==========================================
Files 35 37 +2
Lines 1981 2072 +91
==========================================
+ Hits 1057 1179 +122
+ Misses 924 893 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Updated version of moran's I PR with pre-commits
A new approach to integrate #245