Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Tests #141

Draft
wants to merge 4 commits into
base: ig/normal_model
Choose a base branch
from
Draft

Shape Tests #141

wants to merge 4 commits into from

Conversation

ilan-gold
Copy link
Collaborator

This PR adds some tests around the shapes of implemented methods. Going to have a second pass over this because it's a bit to keep track of. This brings back up what exactly ybar is...stil not sure.

@picciama
Copy link
Collaborator

picciama commented Oct 7, 2022

@ilan-gold do we still need this? In my opinion, we can check all of this during model initialisation, that means during creation of an InputDataGLM object. Everything downstream is using properties from the model class so there everything should be correct.
I.e. x, design_loc/scale, constraints_loc/scale, size_factors, theta_location and theta_scale are to be checked once.

@ilan-gold
Copy link
Collaborator Author

Are you saying we can reliably close this? I understand what you're saying, which makes sense, so we should add a check to the __init__ method? Or you're saying things would break loudly if this were wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants