This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Made password configurable for tranSMART database. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TG908 Hi! Add this information to README. |
|
@ewelinagr will this require a change for entrypoint script of transmart container image? |
|
It looks like the password is set in here but never used. |
|
Indeed, first we need to change transmart-api-server entrypoint to make this working. Here is a link to track the issue on transmart-api-server side: thehyve/transmart-core#472. |
|
I've made the necessary changes: thehyve/transmart-core#473 |
|
any updates on this? |
gijskant
suggested changes
Dec 19, 2019
|
Just a general remark: this user has super user rights on the database. So, it is better to not expose the database port by default, but only accessible for administrators, e.g., not exposing the port to outside the host machine, but only through an SSH tunnel. |
gijskant
reviewed
Dec 19, 2019
gijskant
approved these changes
Dec 20, 2019
tgymnich
force-pushed
the
db_password
branch
from
5575798
to
408665f
Compare
|
done |
ewelinagr
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the tranSMART Database will be exposed by port forwarding it makes sense to make the password user configurable.