This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
tmtk notebook server, SSL proxy for many hosts and Let's Encrypt service #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewelinagr
reviewed
Oct 18, 2019
README.md
Outdated
| ## Running a Jupyter notebook server | ||
|
|
||
| The `startall` script has a flag `--notebook-server` that allows you to run your setup together with a | ||
| [Jupyter](https://jupyter.org) note book server with the [tmtk]((https://pypi.org/project/tmtk/)) and [transmart](https://pypi.org/project/transmart/) |
There was a problem hiding this comment.
note book -> notebook
Extra parenthesis in the tmtk url break the link.
| #!/bin/sh | ||
|
|
||
| # | ||
| # Script to generate configuration for the Let's encrypt service. |
There was a problem hiding this comment.
Maybe useful to shortly mention this script in the README.md
|
|
||
| ARG TMTK_VERSION="0.5.6" | ||
| ARG TRANSMART_API_CLIENT_PY_VERSION="0.2.6" | ||
| ARG TRANSMART_VERSION="17.2.4" |
There was a problem hiding this comment.
Why not make these configurable?
| @@ -0,0 +1,20 @@ | |||
| # Jupyter notebook server with tmtk and TranSMART API client | |||
|
|
|||
| Image to launch a Jupyter notebook server with the `tmtk` and `transmart` | |||
There was a problem hiding this comment.
transmart packages meaning transmart-api-client package, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch has been used to setup the environments for the Tübingen workshop. These changes could be useful in the future. Please review if these changes would have negative consequences for other installations, and if these changes can be improved.