Skip to content

Commit

Permalink
Fixing test
Browse files Browse the repository at this point in the history
  • Loading branch information
thegridman committed Dec 12, 2023
1 parent 158ded5 commit 1cb2762
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
Expand Up @@ -184,9 +184,9 @@ final class Builder implements io.helidon.common.Builder<Builder, GrpcServerConf

private Context context;

private int maxRapidResets;
private int maxRapidResets = 200;

private Duration rapidResetCheckPeriod;
private Duration rapidResetCheckPeriod = Duration.ofSeconds(30);

private Builder() {
}
Expand Down
Expand Up @@ -16,6 +16,7 @@

package io.helidon.grpc.server;

import java.time.Duration;
import java.util.function.Supplier;

import io.helidon.config.Config;
Expand Down Expand Up @@ -222,15 +223,15 @@ public void shouldBuildFromConfig() {
}

@Test
public void shouldHaveDefaultMaxRstFrames() {
public void shouldHaveDefaultMaxRapidResets() {
GrpcServerConfiguration configuration = GrpcServerConfiguration.builder()
.build();

assertThat(configuration.maxRapidResets(), is(200));
}

@Test
public void shouldSetMaxRstFrames() {
public void shouldSetMaxRapidResets() {
GrpcServerConfiguration configuration = GrpcServerConfiguration.builder()
.maxRapidResets(19)
.build();
Expand All @@ -239,20 +240,19 @@ public void shouldSetMaxRstFrames() {
}

@Test
public void shouldSetMaxRstFramesToZero() {
public void shouldHaveDefaultRapidResetCheckPeriod() {
GrpcServerConfiguration configuration = GrpcServerConfiguration.builder()
.maxRapidResets(0)
.build();

assertThat(configuration.maxRapidResets(), is(200));
assertThat(configuration.rapidResetCheckPeriod(), is(Duration.ofSeconds(30)));
}

@Test
public void shouldSetMaxRstFramesToLessThanZero() {
public void shouldSetRapidResetCheckPeriod() {
GrpcServerConfiguration configuration = GrpcServerConfiguration.builder()
.maxRapidResets(-19)
.rapidResetCheckPeriod(Duration.ofSeconds(19))
.build();

assertThat(configuration.maxRapidResets(), is(200));
assertThat(configuration.rapidResetCheckPeriod(), is(Duration.ofSeconds(19)));
}
}

0 comments on commit 1cb2762

Please sign in to comment.