Fixes #37454 - Allow js to be loaded late for react_component #10167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When js component is loaded after a user interaction, for example in app/views/compute_attributes/_compute_form.html.erb
the react_component does not wait for it to be loaded and does not show it.
Found it when a plugin had:
in app/views/hosts/_compute_detail.html.erb
This makes this error to not ever happen: and to always assume that something is not loaded but will be, which is why I left the warning, so the console will still have the info
foreman/webpack/assets/javascripts/react_app/components/componentRegistry.js
Lines 71 to 73 in 9b91cc9