Fixes #37439 - API 'build_pxe_default' with taxonomies #10160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShimShtein
requested changes
May 16, 2024
The 'hammer template build-pxe-default' command works only when no organization or location is passed. The fix is to skip ':find_optional_nested_object' for the 'build_pxe_default' action, as it does not make any sense here.
stejskalleos
force-pushed
the
ls/api/build_pxe_default
branch
from
9442352
to
5e8e66c
Compare
I kept the original one (without taxonomies) and added new one with them. |
|
@ShimShtein can we merge? |
ShimShtein
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hammer template build-pxe-defaultcommand works only when no organization or location is passed.The fix is to skip
:find_optional_nested_objectfor thebuild_pxe_defaultaction, as it does not make sense here.How to test
Check that it works fine