Refactor smart_proxy factories and tests #10143
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the factories consistently use association, which works properly with build and create strategies. They're implemented as traits so can be mixed. Because they're now consistent, it can use loops to define all features.
ekohl
commented
Apr 27, 2024
| before_save :sanitize_url, :associate_features | ||
| # But it can be useful to skip in tests | ||
| attr_accessor :skip_associate_features | ||
| before_save :associate_features, unless: :skip_associate_features |
There was a problem hiding this comment.
I wasn't sure if this was the best way, but it's quite useful in tests to avoid stubbing things.
Comment on lines
+7
to
+8
| subnet = FactoryBot.build_stubbed(:subnet_ipv4, :name => 'My subnet') | ||
| proxy = FactoryBot.build_stubbed(:smart_proxy, :dhcp, subnets: [subnet]) |
There was a problem hiding this comment.
By using build_stubbed it saves a database hit. It would be interesting to see how much more we can save. I'd love to have pure unit tests that can run with nulldb. Perhaps it could even use build.
| proxy_features.each do |feature| | ||
| trait feature do | ||
| smart_proxy_features do | ||
| [association(:smart_proxy_feature, feature, :smart_proxy => @instance)] |
There was a problem hiding this comment.
https://thoughtbot.github.io/factory_bot/cookbook/interconnected-associations.html said you should be able to use instance, but I only got it to work with @instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the factories consistently use association, which works properly with build and create strategies. They're implemented as traits so can be mixed.
Because they're now consistent, it can use loops to define all features.
Currently a draft because I only did limited testing. If this works well, other factories should be cleaned up in a similar way. They can be made a lot shorter and more powerful. With association you can also use build_stubbed in more places, so eventually we can speed up more tests to avoid database interactions.