Fixes #37382 - Update to jQuery 3 #10138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Legacy JS
|
I don't see a bump of jquery itself. Is this removing deprecated jquery < 3 usages? |
|
@ekohl jquery is in theforeman/foreman-js#479 |
ekohl
reviewed
Apr 25, 2024
Comment on lines
172
to
233
| $('#check_all_roles').click(function(e) { | ||
| $('#check_all_roles').on('click', function(e) { | ||
| e.preventDefault(); | ||
| $('.role_checkbox').prop('checked', true); | ||
| }); | ||
|
|
||
| $('#uncheck_all_roles').click(function(e) { | ||
| $('#uncheck_all_roles').on('click', function(e) { |
There was a problem hiding this comment.
There was a problem hiding this comment.
rebased to include that pr
| @@ -1,11 +1,12 @@ | |||
| group :assets do | |||
| gem 'jquery-ui-rails', '~> 6.0' | |||
| gem 'jquery-ui-rails', '~> 7.0' | |||
There was a problem hiding this comment.
Do we still use this? I don't see anything using this. I get the impression that since b55d3ed it's unused because we no longer have require jquery-ui in the code, but we do still have @import jquery-ui. So we load the CSS, but not any of the actual JS code?
Can we drop it?
ekohl
reviewed
May 2, 2024
| $.fn.bind = function(event, func) { | ||
| return this.on(event, func); | ||
| }; | ||
| // used by puppet plugin |
There was a problem hiding this comment.
Perhaps open a PR against foreman_puppet to drop this usage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also need to fix the select2 selectors in plugins, I only found 4 places
https://github.com/search?q=org%3Atheforeman+s2id_++NOT+repo%3Atheforeman%2Fforeman&type=code
https://github.com/search?q=org%3Atheforeman+select2-chosen++NOT+repo%3Atheforeman%2Fforeman&type=code
https://github.com/search?q=s2id_++org%3Akatello&type=code
Requires theforeman/foreman-js#479 to test