Fixes #37398 - Extend TableIndexPage and TableHooks with new capabilities for All Hosts page #10128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
foreman-modal-magic
branch
from
ea8b790
to
12f1b7f
Compare
jeremylenz
changed the title
jeremylenz
force-pushed
the
foreman-modal-magic
branch
from
fffa834
to
100fff9
Compare
jeremylenz
force-pushed
the
foreman-modal-magic
branch
from
100fff9
to
ae81195
Compare
|
Updated package.json with |
|
Packit will still fail, as 13.1.0 ain't packaged yet, but we'll get there |
with new capabilities for All Hosts page - add the option to use `idColumnName` to `<RowSelectTd>` - Add the option to supply your own pagination component in `<Table>` - Add a `hasInteracted` state to `useBulkSelect` - Add a `pushToHistory` option to `useSetParamsAndAPIAndSearch` to skip changing the browser URL - Add `updateParamsByUrl` to `<TableIndexPage>` for the same reason - Add `restrictedSearchQuery` to `<TableIndexPage>`
jeremylenz
force-pushed
the
foreman-modal-magic
branch
from
ae81195
to
60b7481
Compare
|
Testing this PR via Katello/katello#10962 showed no technical issues. |
|
@jeremylenz you dropped the use of |
|
@evgeni Nope, that use is in the Katello PR. |
parthaa
approved these changes
May 15, 2024
jeremylenz
force-pushed
the
foreman-modal-magic
branch
2 times, most recently
from
2f2a294
to
60b7481
Compare
|
Re: React on plugins katello/katello failures, see Katello/katello#10962 (comment) |
|
I plan to wait til after stabilization week to merge this. Will need an ack from @theforeman/packaging then. |
|
Foreman is now branched. @theforeman/packaging are we good here? |
evgeni
approved these changes
May 22, 2024
|
(that ack is purely packaging, I did not look at the code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds several features to TableIndexPage and TableHooks, enabling Katello/katello#10962 to work. Ideally the two PRs should be reviewed together.
idColumnNameto<RowSelectTd>. This is so you can optionally pass in an alternateidColumntouseBulkSelect.<Table>. When using the<TableIndexPage>without specifying children, it was causing some issues with the bottom pagination not being in sync or making API requests. Allowing the parent to specify the bottomPagination solves this, because you can now guarantee that the top and bottom pagination have the same data.hasInteractedstate touseBulkSelect. This is so you can delay showing validations (e.g. for forms and wizards ;) until the user has actually interacted with the component. It's bad UX to throw up a validation message such as "You must select at least one X!!" before the user has even gotten a chance to do anything. I had tried adding this to the pagination functions in Katello, but this solution is much more elegant.pushToHistoryoption touseSetParamsAndAPIAndSearch. When you are using an embedded table (e.g. one that should not keep itself in sync with URL params for search and pagination), you need to be able to skip changing the browser URL.updateParamsByUrlto<TableIndexPage>for the same reason.restrictedSearchQueryto<TableIndexPage>. This allows you to restrict all table rows to ones matching the search you specify here. This restricted search query will not show up visually in the search input, but will be added to the user search in the API request, causing every search to be "within" the restricted search query's results. Usage example: I select 50 hosts and bring up the package install wizard. The package install wizard has the 50 hosts I selected. I am able to search within those and deselect if desired, but I cannot add any hosts to the selection.