cmake modular installation #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedmd
force-pushed
the
develop
branch
2 times, most recently
from
483a8f1
to
7d0f315
Compare
thedmd
force-pushed
the
develop
branch
2 times, most recently
from
6e1cade
to
01fa1b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure weather this change helps or interrupts.
It's definitely not finished and needs work but I require some help with that since I'm still new to CMake.
Main reason I made these changes was to build my application in elegant way.
I wanted to use your "application" class as starting point but I didn't want to wire CMakes to build directory.
After introducing changes, building and installing.
Integration with imgui-node-editor looks like this.
Unfortunately I couldn't come up with solution to PUBLIC include directories.
From my understanding mere linking to imgui_node_editor::imgui_node_editor should make them visible
for the project but It doesn't. Hence ${CMAKE_INSTALL_PREFIX}/../imgui_...