Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dockerfile #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

adamcathersides
Copy link
Contributor

@adamcathersides adamcathersides commented Nov 5, 2018

I have added the tBG bundle to a Dockerfile based on nodecg/nodecg.

Since this base image takes the latest nodecg release (currently 1.2.2) i have bumped the required version in package.json. It still seems to work..

@duckfullstop
Copy link
Collaborator

duckfullstop commented Nov 6, 2018

I disagree with moving things to a separate subdirectory; this git repository is supposed to be just the bundle, not the entire NodeCG setup. (See https://github.com/thebiggame/streamnet_config/tree/master/nodecg)

It's worth noting that other bundles do it this way as well: https://github.com/GamesDoneQuick/agdq18-layouts - this also allows for usage of the nodecg install thebiggame/nodecg_bundle command for quick installation (https://nodecg.com/index.html#installing-bundles), so it's clearly developer intended.

@adamcathersides
Copy link
Contributor Author

adamcathersides commented Nov 6, 2018

Good point didn't think about that aspect. Maybe i'll also put the Dockerfile in a separate repo..thoughts?

Do you see any obvious issue with the version bump?

@duckfullstop
Copy link
Collaborator

Good point didn't think about that aspect. Maybe i'll also put the Dockerfile in a separate repo..thoughts?

Step ahead of you: see https://github.com/thebiggame/streamnet_config/blob/master/nodecg/Dockerfile (though maybe breaking it out of there is sensible?????)

Do you see any obvious issue with the version bump?

Not that I can see from looking at the release notes.

Copy link
Collaborator

@duckfullstop duckfullstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory changes should be removed. Dockerfile should be refactored (and is arguably overkill, see conversation)

Version bump is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants