Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mouse drag panning support and align wheel behavior with KiCad #85

Merged
merged 2 commits into from May 24, 2024

Conversation

sago35
Copy link
Contributor

@sago35 sago35 commented Mar 23, 2024

In this Pull Request, we introduce two main changes to improve the user experience:

  1. Mouse Drag Panning: We have added support for panning through mouse drag. This feature enhances the navigation and makes the interface more intuitive and user-friendly.
  2. Wheel Behavior Alignment with KiCad: When the 'Align controls with KiCad' option is enabled, the wheel behavior is now consistent with KiCad standards. This alignment ensures a familiar and predictable interaction for users accustomed to KiCad's navigation patterns.

Additionally, I have enabled 'Align controls with KiCad' by default to ensure a seamless experience for users transitioning from KiCad.

These enhancements aim to improve usability and ensure consistency with established industry standards.

image

@xobs
Copy link

xobs commented Apr 1, 2024

As a user, I really like this change, and would like to see it merged. I'd also like to see Align controls with KiCad set as default, but then again I usually use a mouse and not a touchpad.

@sago35
Copy link
Contributor Author

sago35 commented Apr 6, 2024

@theacodes
Could you please review this PR?

@sago35
Copy link
Contributor Author

sago35 commented May 23, 2024

@theacodes
Is there a chance you could take a look at this PR?

Copy link
Owner

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks great, just some small notes

src/base/dom/pan-and-zoom.ts Outdated Show resolved Hide resolved
src/base/dom/pan-and-zoom.ts Outdated Show resolved Hide resolved
src/base/dom/pan-and-zoom.ts Outdated Show resolved Hide resolved
@sago35
Copy link
Contributor Author

sago35 commented May 24, 2024

@theacodes
Thank you for reviewing. I apologize for the unnecessary parts that were left. I have fixed the issues you pointed out, and it is now ready for review again.

Copy link
Owner

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for doing this. :)

Also no need to apologize! Code review exists for a reason. :D

@theacodes theacodes merged commit 97060a1 into theacodes:main May 24, 2024
2 checks passed
@sago35 sago35 deleted the kicad-mouse branch May 24, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants