Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 7 #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunny
Copy link
Contributor

@sunny sunny commented Aug 4, 2021

Required to support the latest version of Rails.

Simplified the loop as well in order for automated tools such as dependabot to more easily create automated pull requests.

Use this in your Gemfile in the meantime:

# Using branch to support Rails 7
# https://github.com/the-refinery/sparkpost_rails/pull/89
gem "sparkpost_rails",
    git: "https://github.com/sunny/sparkpost_rails.git",
    branch: "allow-rails-seven"

@sunny sunny changed the title Allow Rails 7 Add support for Rails 7 Aug 4, 2021
@sunny sunny changed the title Add support for Rails 7 Add support for Rails main branch Aug 19, 2021
@sunny sunny changed the title Add support for Rails main branch Add support for Rails main (7.0.0.alpha) Aug 19, 2021
@trueheart78
Copy link

Would it make sense to bump this to support support Rails 7.0.0 final?

@sunny sunny changed the title Add support for Rails main (7.0.0.alpha) Add support for Rails 7 Dec 16, 2021
@sunny
Copy link
Contributor Author

sunny commented Dec 16, 2021

Done!

@trueheart78
Copy link

Awesome!

Captain Marvel

@dpaola2
Copy link

dpaola2 commented Apr 21, 2022

Thanks for this. Wondering if this could be merged to master

@olliebennett
Copy link

olliebennett commented Apr 26, 2022

I can confirm I've been using this branch in production for 2 months without any issues. Would love to see it released if possible! :)

@jmlagace
Copy link

Any updates on this merge request?

@brandoncc
Copy link

I'd love to see this merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants