Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification-dot for user with unverified account_status #724

Merged
merged 11 commits into from
May 16, 2024

Conversation

BenjaminCharmes
Copy link
Member

Related to #710

Add more UI hints for unverified users (red dot next to their name in account settings), and the same hint for admins that a user has asked to be verified (this could also trigger an email send at some point).

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.89%. Comparing base (af58b42) to head (374d981).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   66.89%   66.89%           
=======================================
  Files          62       62           
  Lines        3727     3727           
=======================================
  Hits         2493     2493           
  Misses       1234     1234           

Copy link

cypress bot commented May 3, 2024

Passing run #1763 ↗︎

0 40 0 0 Flakiness 0

Details:

Merge 374d981 into af58b42...
Project: datalab Commit: 67d4e83b9c ℹ️
Status: Passed Duration: 02:13 💡
Started: May 16, 2024 2:13 PM Ended: May 16, 2024 2:16 PM

Review all test suite changes for PR #724 ↗︎

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, one minor adjustment

webapp/src/components/UserBubble.vue Outdated Show resolved Hide resolved
@BenjaminCharmes
Copy link
Member Author

pre-commit.ci autofix

@BenjaminCharmes BenjaminCharmes changed the title [WIP] Add notification-dot for user with unverified account_status Add notification-dot for user with unverified account_status May 13, 2024
@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review May 13, 2024 15:41
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BenjaminCharmes, thanks!

@ml-evs ml-evs enabled auto-merge (squash) May 16, 2024 14:13
@ml-evs ml-evs disabled auto-merge May 16, 2024 14:25
@ml-evs ml-evs merged commit f98ff00 into main May 16, 2024
11 checks passed
@ml-evs ml-evs deleted the bc/ui-hint-unverified branch May 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants