Populating dynamic block-level documentation as UI tooltips #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 66.92% 66.91% -0.01%
==========================================
Files 62 62
Lines 3713 3712 -1
==========================================
- Hits 2485 2484 -1
Misses 1228 1228
|
Passing run #1742 ↗︎
Details:
Review all test suite changes for PR #719 ↗︎ |
|||||||||||||||
ml-evs
reviewed
May 8, 2024
|
pre-commit.ci autofix |
BenjaminCharmes
changed the title
ml-evs
force-pushed
the
bc/ui-documentation
branch
from
4f1ec6f
to
cbcd3dd
Compare
ml-evs
reviewed
May 15, 2024
There was a problem hiding this comment.
Looking good, I'm going to test this out locally and push the tweaks mentioned and if all works, will go ahead and merge.
Thanks @BenjaminCharmes
ml-evs
reviewed
May 15, 2024
ml-evs
reviewed
May 15, 2024
ml-evs
previously approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM now @BenjaminCharmes! I'll have a follow up PR that uses some of this stuff to make at tooltip inside the block title too
for more information, see https://pre-commit.ci
Allow txt files in MS block again
ml-evs
force-pushed
the
bc/ui-documentation
branch
from
4a05535
to
63dabcd
Compare
ml-evs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #705 & #667
Add information for each block with popper.js on hover in the “Add a block” dropdown inside the EditPage.
The names in the dropdown are slightly different, as we now use those fetched directly from the models and not those in @resource.js (can be change if needed).
The design of the popper.js window is customizable, so don't hesitate to give me feedback.