Handle deployment settings in a new collection in the database #716
Conversation
…update them in the admin dashboard
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 66.92% 66.13% -0.80%
==========================================
Files 62 62
Lines 3713 3768 +55
==========================================
+ Hits 2485 2492 +7
- Misses 1228 1276 +48
|
Passing run #1701 ↗︎
Details:
Review all test suite changes for PR #716 ↗︎ |
|||||||||||||||
|
pre-commit.ci autofix |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
ml-evs
changed the title
There was a problem hiding this comment.
Looking good, will need to hear more about what @jdbocarsly wants to use this for before deciding whether new settings should be created and whether we need to enumerate any defaults
| 200, | ||
| ) | ||
|
|
||
| return (jsonify({"status": "success"}), 200) |
There was a problem hiding this comment.
As we discussed, maybe add a route for also creating a new setting that can have a simple string name/value (and maybe description?) plus whether it is public or private as a drop down
There was a problem hiding this comment.
Done. For the moment, only the "LOGO_URL" and "HOMEPAGE_URL" settings work. So I also put a dropdown for "name" with only these two entries.
…ing, a 'description' field and model deletion
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
I think much like #604, there's enough to tidy up here (and stuff that could subtly break deployments) that we should hold off until after the 0.4 release to merge this. |
|
As discussed during the datalab meeting and for future work:
|
Closes #704
Should we have a default value for certain parameters defined in the code? or
Have an empty field in the admin dashboard for parameters not yet defined? or
Just enter them manually in the database the first time?