Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset unsaved warning after getSampleData() receives data #606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jdbocarsly
Copy link
Member

Simple fix to prevent the annoying bug where the unsaved warning erroneously appears whenever a sample or cell page is loaded a second time without a refresh.

closes #601

Copy link

cypress bot commented Feb 19, 2024

Passing run #1060 ↗︎

0 26 0 0 Flakiness 0

Details:

Merge 4ff447c into 8dd6c1f...
Project: datalab Commit: 81b5011f77 ℹ️
Status: Passed Duration: 01:42 💡
Started: Feb 27, 2024 4:22 PM Ended: Feb 27, 2024 4:24 PM

Review all test suite changes for PR #606 ↗︎

@jdbocarsly
Copy link
Member Author

@ml-evs , can you deploy this to dev when you get a chance? Would like to test it on a real server with latency, etc.

@ml-evs
Copy link
Member

ml-evs commented Feb 20, 2024

@ml-evs , can you deploy this to dev when you get a chance? Would like to test it on a real server with latency, etc.

Deployed on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unsaved changes" warning appears on loading a sample a second time, after using the browser back button
2 participants