Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to have selectable color field in selectable_axes_plot #374

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdbocarsly
Copy link
Member

Building on the recent generalizations of the selectable_axes_plot, this branch starts to add functionality to allow for selcting a field that controls the color of the points.

@jdbocarsly
Copy link
Member Author

jdbocarsly commented May 9, 2023

This current version has two issues:

  • It only works when there is only one set of data shown. It seems to crash the site if there are multiple. In general, this can be fixed fairly easily, but I'm not really sure what the use case for having multiple data sets, each colored with color maps would be- needs to be discussed.
  • The label/title of the colorbar doesn't update properly, which is a bug in the version of bokeh we use. Apparently it should be fixed in v3.0+, so we would want to look at updating before deploying this feature.

@cypress
Copy link

cypress bot commented May 9, 2023

Passing run #288 ↗︎

0 45 0 0 Flakiness 0

Details:

Merge bfb1987 into d82a073...
Project: datalab Commit: 8e101b474a ℹ️
Status: Passed Duration: 04:20 💡
Started: May 9, 2023 9:29 AM Ended: May 9, 2023 9:33 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant