New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Quart ASGI server to Uvicorn and disable logging #387
Conversation
As this is a HTTP/1 benchmarking exercise Uvicorn is sufficient and faster than Hypercorn. Note that Uvicorn does not, as yet, support multiple workers. As logging seems to be disabled in other projects, it should be here as it makes a large difference to the performance.
Thanks for your contribution @pgjones
|
I don't think the workers option is in a released uvicorn yet, for me 0.3.5 gives |
ok I was running on |
I have those results
but I can explain the ratio by @tomchristie I have seen encode/uvicorn#141, but will multi-worker feature will be planed ? |
@pgjones using |
Comparing
@pgjones Thanks for your suggestion 🎉 I think |
Sure, go ahead. |
@pgjones I can not push on master ;-) |
Yeah at the moment the story for multiple workers is “use a process manager”, eg gunicorn/supervisor/circus. We’re recommending that because they’re all super mature and handle monitoring processes & restarting etc. However for convienience I think we will add multiple workers back in at some point soonish. |
@waghanza Ah, I thought you were going to cherry-pick and edit the commit (which I'd prefer rather than pushing to my fork). Feel free to close this and take the commit and do whatever... |
Close for #387 |
As this is a HTTP/1 benchmarking exercise Uvicorn is sufficient and
faster than Hypercorn. Note that Uvicorn does not, as yet, support
multiple workers.
As logging seems to be disabled in other projects, it should be here
as it makes a large difference to the performance.