Adds extra signals for storage add/remove, + minor signal doc #83247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMelbert
reviewed
May 15, 2024
MrMelbert
reviewed
May 15, 2024
MrMelbert
reviewed
May 15, 2024
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
nikothedude
changed the title
nikothedude
changed the title
ZephyrTFA
requested changes
May 17, 2024
comfyorange
added a commit
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Title.
Converts TCG decks to use signals instead of a proc override, as is better practice.
Why It's Good For The Game
It's generally better practice to not snowflake behavior like this onto the storage itself, instead using signals/procs.
Also, its good to have parity between add/remove in signals.
Changelog
馃啈
code: New signals for atom storage remove and insert
/:cl: