Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Crutches to Medbay & Crafting #83242

Merged
merged 17 commits into from
Jun 1, 2024
Merged

Conversation

carlarctg
Copy link
Contributor

@carlarctg carlarctg commented May 15, 2024

About The Pull Request

Added crutches! Wooden ones can be made with wood. Medical ones can be bought from the medvendor.

Crutches will reduce slowdown from missing a leg by 60%, and they will remove the limping from fractured bones. They're also a fairly decent bludgeon. However, they do nothing if both legs are cut off. Canes now also remove broken bone limping as well

Changed the 'white cane' name to 'probing cane' to better reflect its function.

Shuffled some wound and mob code around, added signals for limbless slowdown and limping.

Crutches make you waddle.

SPRITES BY XHORIAN!!!!!!!!!!!!!

image
image
image
image

Why It's Good For The Game

Added crutches! Wooden ones can be made with wood. Medical ones can be bought from the medvendor.

Crutches will reduce slowdown from missing a leg by 60%, and they will remove the limping from broken bones. They're also a fairly decent bludgeon. However, they do nothing if both legs are cut off.

Currently there's no way to abate slowdown from a missing leg except getting on a vehicle, which I think is pretty lame. What if all the doctors are busy, missing, or dead? What if medbay is a hole? A crutch helps make up for the loss at the cost of a hand slot.

Changed the 'white cane' name to 'probing cane' to better reflect its function.

'White cane' was undescriptive.

Shuffled some wound and mob code around, added signals for limbless slowdown and limping.

I dont know where to put the friggin signals

Changelog

🆑
Carlarc, Xhorian
add: Added crutches! Wooden ones can be made with wood. Medical ones can be bought from the medvendor.
add: Crutches will reduce slowdown from missing a leg by 60%, and they will remove the limping from fractured bones. (canes do that now too) They're also a fairly decent bludgeon. However, they do nothing if both legs are cut off.
/:cl:

@tgstation-server tgstation-server added Sprites A bikeshed full of soulless bikes. Grammar and Formatting Speling and grammar, can be hard sometimes Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts Feature Exposes new bugs in interesting ways labels May 15, 2024
@atlasle
Copy link
Contributor

atlasle commented May 15, 2024

is there a difference between the two? if not could you make it so the wooden cane is dropped when you get shoved

@Sadboysuss
Copy link
Contributor

would be nice if you could include a picture of the crutch in use and what it looks like on the floor

@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label May 15, 2024
@Jacquerel
Copy link
Contributor

Putting in screenshots of inhand sprites from vscode is both lazy and pointless: show them in game or don't bother.
They're not worth looking at without the only context they will be displayed in: being attached to a mob.

@Admiral-Gigaton
Copy link

wouldn't normal canes fall under at least the limping bit? (if it doesnt already do something like that) could you include the normal cane in this category

@DATA-xPUNGED
Copy link
Contributor

Will this help hemiplegic people?

@Sadboysuss
Copy link
Contributor

Sadboysuss commented May 15, 2024

Will this help hemiplegic people?

it should probably take up the hand slot on the side which your leg is missing, but I don't think it does that right now

@improvedname
Copy link
Contributor

you should be able to use two to still stand up with no legs and each time you attack with no legs you should fall down on the ground dropping your crutches 🥹

@carlarctg
Copy link
Contributor Author

Will this help hemiplegic people?

it should probably take up the hand slot on the side which your leg is missing, but I don't think it does that right now

i dont see a reason to do that, just adds annoyance

code/datums/status_effects/wound_effects.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Show resolved Hide resolved
code/modules/mob/living/living.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
@MrMelbert MrMelbert marked this pull request as draft May 15, 2024 18:37
@Gaxeer
Copy link
Contributor

Gaxeer commented May 16, 2024

This time crutches are actually added in game, not in the code :D

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Copy link
Contributor

@Wallemations Wallemations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the foot(?) of the obj sprite (not mob sprite) is a bit wide imo, but otherwise is fine
Idk what you call the nub at the bottom of the crutch that touches the floor

@carlarctg carlarctg marked this pull request as ready for review May 22, 2024 23:58
@ExcessiveUseOfCobblestone
Copy link
Contributor

cute

Copy link
Contributor

@Wallemations Wallemations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New sprites look good

code/game/objects/items/weaponry.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Grammar and Formatting Speling and grammar, can be hard sometimes Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet