Fixes wings working in space #83239
Merged
Fixes wings working in space #83239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lufferly
requested review from
ExcessiveUseOfCobblestone and
Ryll-Ryll
as code owners
tgstation-server
added
the
Fix
|
I remember fixing this too 6 years ago lmao |
ShizCalev
approved these changes
May 15, 2024
Time-Green
reviewed
May 15, 2024
| @@ -50,7 +50,7 @@ | |||
|
|
|||
| ///Called on_life(). Handle flight code and check if we're still flying | |||
| /obj/item/organ/external/wings/functional/proc/handle_flight(mob/living/carbon/human/human) | |||
| if(human.movement_type & ~FLYING) | |||
| if(!(human.movement_type & FLYING)) | |||
There was a problem hiding this comment.
I was about to correct you on this and then realized I'm the idiot that mixes up binary operators and added this bug in the first place
comfyorange
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #82035
Fixes #82184
Wings no longer are able to function in space if you activated them in an environment they can function in.
This surfaced another bug where the wings would stop flying but would leave the mob in a weird state where they weren't flying but were still negating gravity, calling refresh_gravity fixed this, if this is a bad way to do this let me know.
Why It's Good For The Game
Bugfix, wings not working in space is an intentional balance consideration.
Changelog
馃啈 Seven
fix: Wings no longer work in space if you activated them beforehand.
/:cl: