Changes how lube crawling works and fixes a bug with snails #83238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnFulpWillard
requested review from
ExcessiveUseOfCobblestone,
Ryll-Ryll,
Jacquerel,
san7890 and
tralezab
as code owners
tgstation-server
added
Fix
MrMelbert
reviewed
May 14, 2024
Comment on lines
105
to
106
| ///Multiplier for the race's speed. Positive numbers make it move slower, negative numbers make it move faster. | ||
| var/speedmod = 0 |
There was a problem hiding this comment.
If we're reverting this JUST for snails then why not JUST make it handled by /datum/species/snail than slapping it back on /datum/species?
MrMelbert
reviewed
May 14, 2024
|
4th iteration of snailcrawl lets goooooo |
Ghommie
approved these changes
May 16, 2024
comfyorange
added a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This partially reverts #76336 - Just for slimepeople since it's the only one that felt important to be tied to species.
Snails are currently pretty fast when they are crawling around, but on top of that they are also able to get their legs replaced to become 3x faster than normal humans while resting. It's a little silly, and I thought I should fix it.
I also changed the element itself to be easier for admins to edit, giving them control over time and wet flags, and made it work a little better.
Instead of being hardcoded to listen to carbons and to register every step to check if they are resting, calling add/remove movespeed modifier every single time they move, we are told whether they have to be resting, and update when they get up/lie down. This has an extra bonus that admins can control whether or not they want to make simple/basic animals have to rest to lube things (like cats).
Why It's Good For The Game
Closes #78417
Makes the lube spitting element that (primarily) snails use into a more general thing that can be used by admins or other contributors that want to make things wet thing as they walk for some time.
Also no insanely fast snails anymore.
Changelog
馃啈
fix: Snails no longer move at normal speed while resting.
fix: Snails can no longer get insane speed from getting their legs replaced.
fix: Humans don't become immensely slow when getting a Snail leg.
admin: lube walking element is now much easier to mess with to fit however you want to use it for.
/:cl: