OpenDream fast del() support #83237
Closed
OpenDream fast del() support #83237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
the
Performance
|
this wont work because you change the define entirely which means switch statements / if statements will perform logic wrong |
|
Can confirm OpenDream spends more time queuing things in SSgarbage than it would take to just harddel them. |
Cyberboss
force-pushed
the
ODqdel
branch
2 times, most recently
from
f3e1ef1
to
81c2ebd
Compare
|
Also there's no reason outside of unit test times to speed this up queue size impacts very little |
|
Not safe as existing code expects a vague valid reference window and this voids that contract |
|
I fixed that by using |
#ifdef OPENDREAM
if(hint != QDEL_HINT_IWILLGC || hint != QDEL_HINT_LETMELIVE)
hint = QDEL_HINT_HARDDEL
#endifjust fucking use this in /proc/qdel |
Cyberboss
force-pushed
the
ODqdel
branch
2 times, most recently
from
f7d3c62
to
99739a7
Compare
|
bikeshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Skips GC on OpenDream
Why It's Good For The Game
OpenDream's implementation makes del() super fast and not to be feared. Save a ton of bytecode processing by ridding the queue logic.
Changelog
Not really.