Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some atoms conduct electricity flag #83230

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

RengaN02
Copy link
Contributor

@RengaN02 RengaN02 commented May 14, 2024

About The Pull Request

Fixes: #83229
I think this code was done this way by a little mistake, and a metal sword should conduct electricity anyway (right?).

Gif

Why It's Good For The Game

its a fix

Changelog

馃啈 Rengan
fix: Officers sabre and grilles now conducts electricity as it should.
/:cl:

@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label May 14, 2024
@Sadboysuss
Copy link
Contributor

it has a leather hilt so I don't think it would conduct electricity to your arm.

@RengaN02
Copy link
Contributor Author

it has a leather hilt so I don't think it would conduct electricity to your arm.

you are right but also fireaxe conducts electricty, it has wooden handle

screwdriver conducts electricity but it has plastic

@ShizCalev
Copy link
Member

image
Another wrong one.

Caused by #80033

Copy link
Member

@ShizCalev ShizCalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get grilles too please.

@RengaN02
Copy link
Contributor Author

Get grilles too please.

馃憤

@RengaN02 RengaN02 changed the title Fixes sabres conduct electricity flag Fixes some atoms conduct electricity flag May 15, 2024
@RengaN02 RengaN02 requested a review from ShizCalev May 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Good First PR We all have to start somewhere
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captains sabre doesnt conducts electricity
5 participants