Fix: You cant be shade if you toggled off the role #83194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Fix
|
Why would we tie a shade ban to a wizard ban? I don't think this makes a lot of sense. |
But same for cult, why shade checks cult ban.it can be holy shade or wizard shade. |
|
Actually my brain stopped braining, im closing the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes: #82925
And i added theme check for role and check_jobban so if soulstone's theme is wizard and if you banned from wizard you cant be shade.
Why It's Good For The Game
This is a fix
Changelog
馃啈
fix: Now if you disabled cultist role, you cant be cultist shade and same for the wizard..
/:cl: