Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some bitrunning related issues [no gbp] #83184

Merged
merged 2 commits into from
May 15, 2024
Merged

Fixes some bitrunning related issues [no gbp] #83184

merged 2 commits into from
May 15, 2024

Conversation

jlsnow301
Copy link
Contributor

@jlsnow301 jlsnow301 commented May 11, 2024 •
edited by github-actions bot

About The Pull Request

Properly allows bitrunning antagonists to come station side

A few issues were resolved:

  • Event title was too lengthy, it's been renamed
  • IDs were not being named properly for cyber police. Cybertac would appear as "unknown"
  • Runtime at examining cyber police ID because it had an erroneous account
  • Teleporting station side would delete your organs and leave you a broken husk of a mob

Why It's Good For The Game

Fixes #83181

Changelog

馃啈
fix: Bitrunning antagonists no longer gib on teleport
fix: Cyber tac now have a visible name / ID
fix: Renamed the bitrunning malfunction event to just "Malfunction: x"
/:cl:

@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR labels May 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 11, 2024 •
edited

This pull request was test merged in 16 round(s).

Round list

manuel

@Sadboysuss
Copy link
Contributor

why was this test merged?

@jlsnow301 @Time-Green
review
136b52f 
Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
@Ghommie Ghommie merged commit fce5209 into tgstation:master May 15, 2024
19 checks passed
@NovaBot13 NovaBot13 mentioned this pull request May 15, 2024
Merged
@SkyratBot SkyratBot mentioned this pull request May 15, 2024
Merged
comfyorange added a commit that referenced this pull request May 15, 2024
@comfyorange
Automatic changelog for PR #83184 [ci skip]
9748ccd
@Steals-The-PRs Steals-The-PRs mentioned this pull request May 15, 2024
Merged
@jlsnow301 jlsnow301 deleted the cyber-pol branch May 15, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Time-Green Time-Green Time-Green left review comments

@Ghommie Ghommie Ghommie approved these changes

Assignees
No one assigned
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

human bitrunning glitches get gibbed when attempting to escape the domain through an emagged server
5 participants
@jlsnow301 @Sadboysuss @Time-Green @Ghommie @tgstation-server