-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the RMB action on the cigarettes pack and add a new QoL #83170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Fix
Rewrites a bug so it appears in different circumstances
Quality of Life
Increasing esword damage is not a quality of life for traitors
labels
May 10, 2024
oh, wait, there's a pr thar reworks cigarettes #82942 (comment). |
By the looks if it, there won't be much conflict between the two PRs. You'll have to update the cigarette path used (line 243) but you should be fine otherwise. |
MrMelbert
requested changes
May 10, 2024
comfyorange
added a commit
that referenced
this pull request
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Fix
Rewrites a bug so it appears in different circumstances
Quality of Life
Increasing esword damage is not a quality of life for traitors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fix the movement of a pack of cigarettes under an spaceman when they interacts with it with the right mouse button.
Also adds a new way to quickly insert cigarettes in the mouth, just hitting a pack of cigarettes on yourself. Here how it works:
2024-05-10.15-55-11.mp4
Why It's Good For The Game
It fixes the bug and adds a new quick and convenient way to put a cigarette in your mouth. That's good, isn't it?
Changelog
馃啈
qol: Now you can put a cigarette in your mouth just by hitting the pack of cigarettes on yourself.
fix: The cigarette pack no longer moves under the spaceman when they interacts with it with the RMB
/:cl: