Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals now make sounds #83166

Merged
merged 8 commits into from
May 15, 2024
Merged

Portals now make sounds #83166

merged 8 commits into from
May 15, 2024

Conversation

Sadboysuss
Copy link
Contributor

@Sadboysuss Sadboysuss commented May 9, 2024

About The Pull Request

New sounds:

https://drive.google.com/drive/folders/1vLoyxY93Qfe_GtCnetkEHLrkGYZ8S7nD?usp=sharing

Demo:

bandicam.2024-05-13.12-46-50-857.mp4

Changes teleporter,gulag teleporter, hand tele, bluespace teleport gun, cultist teleport, experimental syndicate teleporter teleport sounds.

Why It's Good For The Game

I think sounds are an integral part of immersion and having no cool sci-fi noises for portals really spoils it.

Changelog

馃啈 grungussuss and Virgilcore
sound: portals now have a unique sound to them
/:cl:

@Sadboysuss Sadboysuss requested a review from Fikou as a code owner May 9, 2024 21:23
@tgstation-server tgstation-server added the Sound Oh god my ears, they bleed, did you normalise the volume? label May 9, 2024
@Sadboysuss Sadboysuss changed the title Portal now make sounds Portals now make sounds May 9, 2024
@EricZilla
Copy link
Contributor

Super cool!

@atlasle
Copy link
Contributor

atlasle commented May 10, 2024

have you thought about adding a passive hum as well?

@Sadboysuss
Copy link
Contributor Author

have you thought about adding a passive hum as well?

nah

@Jacquerel
Copy link
Contributor

I like these but I think the backwards sound when they despawn sounds a little bit silly

@VirgilCore
Copy link

have you thought about adding a passive hum as well?

I considered making a sound for it. If Grungus wants me to make it, I can.

I like these but I think the backwards sound when they despawn sounds a little bit silly

I think its partly because of Grungus's implimentation of my sound effects. They sound slowed down in game, so i'm going to adjust my closing sound to better accomidate this, and make it sound less like a reversed opening sound.

@Jacquerel
Copy link
Contributor

It likely sounds slowed down in the example because frequency variance is enabled- meaning it has a slightly randomised frequency when it is played
This provides a bit of variety if you are likely to hear the sound repeatedly in a short span of time but also does of course make the sound less like how a sound engineer designed it

@NullDagaf
Copy link

Should make them sound like Portal portals.

@EricZilla
Copy link
Contributor

These are super cool

@Sadboysuss
Copy link
Contributor Author

It likely sounds slowed down in the example because frequency variance is enabled- meaning it has a slightly randomised frequency when it is played This provides a bit of variety if you are likely to hear the sound repeatedly in a short span of time but also does of course make the sound less like how a sound engineer designed it

Turned off vary for the closing sound and updated the demo video.

@Ghommie Ghommie merged commit 8b8934c into tgstation:master May 15, 2024
19 checks passed
comfyorange added a commit that referenced this pull request May 15, 2024
github-actions bot added a commit that referenced this pull request May 15, 2024
@Sadboysuss Sadboysuss deleted the teleport-sounds branch May 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sound Oh god my ears, they bleed, did you normalise the volume?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants